aboutsummaryrefslogtreecommitdiffstats
path: root/net/netfilter
diff options
context:
space:
mode:
authorShakeel Butt <shakeelb@google.com>2019-01-02 19:14:31 -0800
committerPablo Neira Ayuso <pablo@netfilter.org>2019-01-11 00:55:36 +0100
commite2c8d550a973bb34fc28bc8d0ec996f84562fb8a (patch)
treed7edea808d7b53c91e3139b845e513c1d4a78eb2 /net/netfilter
parentnetfilter: nft_flow_offload: Fix reverse route lookup (diff)
downloadlinux-dev-e2c8d550a973bb34fc28bc8d0ec996f84562fb8a.tar.xz
linux-dev-e2c8d550a973bb34fc28bc8d0ec996f84562fb8a.zip
netfilter: ebtables: account ebt_table_info to kmemcg
The [ip,ip6,arp]_tables use x_tables_info internally and the underlying memory is already accounted to kmemcg. Do the same for ebtables. The syzbot, by using setsockopt(EBT_SO_SET_ENTRIES), was able to OOM the whole system from a restricted memcg, a potential DoS. By accounting the ebt_table_info, the memory used for ebt_table_info can be contained within the memcg of the allocating process. However the lifetime of ebt_table_info is independent of the allocating process and is tied to the network namespace. So, the oom-killer will not be able to relieve the memory pressure due to ebt_table_info memory. The memory for ebt_table_info is allocated through vmalloc. Currently vmalloc does not handle the oom-killed allocating process correctly and one large allocation can bypass memcg limit enforcement. So, with this patch, at least the small allocations will be contained. For large allocations, we need to fix vmalloc. Reported-by: syzbot+7713f3aa67be76b1552c@syzkaller.appspotmail.com Signed-off-by: Shakeel Butt <shakeelb@google.com> Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter')
0 files changed, 0 insertions, 0 deletions