diff options
| author |   Salvatore Mesoraca <s.mesoraca16@gmail.com> | 2018-03-11 22:07:50 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-12 15:07:00 -0400 |
| commit | b2c9272ae7d366e85ab277f528c3dddb7f268b12 (patch) | |
| tree | 46ba306a8823a48cc847744a38a5a68ab4bb3154 /net/rds | |
| parent | net: rds: drop VLA in rds_for_each_conn_info() (diff) | |
| download | linux-dev-b2c9272ae7d366e85ab277f528c3dddb7f268b12.tar.xz linux-dev-b2c9272ae7d366e85ab277f528c3dddb7f268b12.zip | |
net: rds: drop VLA in rds_walk_conn_path_info()
Avoid VLA[1] by using an already allocated buffer passed
by the caller.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
| -rw-r--r-- | net/rds/connection.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/rds/connection.c b/net/rds/connection.c index f80792c719eb..abef75da89a7 100644 --- a/net/rds/connection.c +++ b/net/rds/connection.c @@ -578,9 +578,9 @@ static void rds_walk_conn_path_info(struct socket *sock, unsigned int len, struct rds_info_iterator *iter, struct rds_info_lengths *lens, int (*visitor)(struct rds_conn_path *, void *), + u64 *buffer, size_t item_len) { - u64 buffer[(item_len + 7) / 8]; struct hlist_head *head; struct rds_connection *conn; size_t i; @@ -649,8 +649,11 @@ static void rds_conn_info(struct socket *sock, unsigned int len, struct rds_info_iterator *iter, struct rds_info_lengths *lens) { + u64 buffer[(sizeof(struct rds_info_connection) + 7) / 8]; + rds_walk_conn_path_info(sock, len, iter, lens, rds_conn_info_visitor, + buffer, sizeof(struct rds_info_connection)); } |