diff options
| author |   David S. Miller <davem@davemloft.net> | 2018-07-08 17:02:59 +0900 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-08 17:02:59 +0900 |
| commit | 0dbc81eab4d13f6d295da69c00e6efee2427b55c (patch) | |
| tree | 1d96c91f21d0fe00842d48273f5dd2c219a28e78 /net/sched/act_api.c | |
| parent | Merge branch 'Modify-action-API-for-implementing-lockless-actions' (diff) | |
| download | linux-dev-0dbc81eab4d13f6d295da69c00e6efee2427b55c.tar.xz linux-dev-0dbc81eab4d13f6d295da69c00e6efee2427b55c.zip | |
net: sched: Fix warnings from xchg() on RCU'd cookie pointer.
The kbuild test robot reports:
>> net/sched/act_api.c:71:15: sparse: incorrect type in initializer (different address spaces) @@ expected struct tc_cookie [noderef] <asn:4>*__ret @@ got [noderef] <asn:4>*__ret @@
net/sched/act_api.c:71:15: expected struct tc_cookie [noderef] <asn:4>*__ret
net/sched/act_api.c:71:15: got struct tc_cookie *new_cookie
>> net/sched/act_api.c:71:13: sparse: incorrect type in assignment (different address spaces) @@ expected struct tc_cookie *old @@ got struct tc_cookie [noderef] <struct tc_cookie *old @@
net/sched/act_api.c:71:13: expected struct tc_cookie *old
net/sched/act_api.c:71:13: got struct tc_cookie [noderef] <asn:4>*[assigned] __ret
>> net/sched/act_api.c:132:48: sparse: dereference of noderef expression
Handle this in the usual way by force casting away the __rcu annotation
when we are using xchg() on it.
Fixes: eec94fdb0480 ("net: sched: use rcu for action cookie update")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_api.c')
| -rw-r--r-- | net/sched/act_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_api.c b/net/sched/act_api.c index bf1c35f3deb6..66dc19746c63 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -68,7 +68,7 @@ static void tcf_set_action_cookie(struct tc_cookie __rcu **old_cookie, { struct tc_cookie *old; - old = xchg(old_cookie, new_cookie); + old = xchg((__force struct tc_cookie **)old_cookie, new_cookie); if (old) call_rcu(&old->rcu, tcf_free_cookie_rcu); } |