diff options
| author |   Davide Caratti <dcaratti@redhat.com> | 2018-03-19 15:31:25 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-03-21 18:12:08 -0400 |
| commit | 94fa3f929ec0c048b1f3658cc335b940df4f6d22 (patch) | |
| tree | cca6e145d1e30ccea1e569a1f09a3e9b370095bb /net/sched/act_skbmod.c | |
| parent | net/sched: fix idr leak in the error path of tcf_act_police_init() (diff) | |
| download | linux-dev-94fa3f929ec0c048b1f3658cc335b940df4f6d22.tar.xz linux-dev-94fa3f929ec0c048b1f3658cc335b940df4f6d22.zip | |
net/sched: fix idr leak in the error path of tcp_pedit_init()
tcf_pedit_init() can fail to allocate 'keys' after the idr has been
successfully reserved. When this happens, subsequent attempts to configure
a pedit rule using the same idr value systematically fail with -ENOSPC:
# tc action add action pedit munge ip ttl set 63 index 100
RTNETLINK answers: Cannot allocate memory
We have an error talking to the kernel
# tc action add action pedit munge ip ttl set 63 index 100
RTNETLINK answers: No space left on device
We have an error talking to the kernel
# tc action add action pedit munge ip ttl set 63 index 100
RTNETLINK answers: No space left on device
We have an error talking to the kernel
...
Fix this in the error path of tcf_act_pedit_init(), calling
tcf_idr_release() in place of tcf_idr_cleanup().
Fixes: 65a206c01e8e ("net/sched: Change act_api and act_xxx modules to use IDR")
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_skbmod.c')
0 files changed, 0 insertions, 0 deletions