diff options
| author |   Davide Caratti <dcaratti@redhat.com> | 2018-05-16 12:54:29 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-05-16 14:41:44 -0400 |
| commit | 5a4931ae0193f8a4a97e8260fd0df1d705d83299 (patch) | |
| tree | e04538461d81b1e57d5f07516553357d1719a336 /net/sched/act_vlan.c | |
| parent | net: 8390: ne: Fix accidentally removed RBTX4927 support (diff) | |
| download | linux-dev-5a4931ae0193f8a4a97e8260fd0df1d705d83299.tar.xz linux-dev-5a4931ae0193f8a4a97e8260fd0df1d705d83299.zip | |
net/sched: fix refcnt leak in the error path of tcf_vlan_init()
Similarly to what was done with commit a52956dfc503 ("net sched actions:
fix refcnt leak in skbmod"), fix the error path of tcf_vlan_init() to avoid
refcnt leaks when wrong value of TCA_VLAN_PUSH_VLAN_PROTOCOL is given.
Fixes: 5026c9b1bafc ("net sched: vlan action fix late binding")
CC: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/act_vlan.c')
| -rw-r--r-- | net/sched/act_vlan.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c index 853604685965..1fb39e1f9d07 100644 --- a/net/sched/act_vlan.c +++ b/net/sched/act_vlan.c @@ -161,6 +161,8 @@ static int tcf_vlan_init(struct net *net, struct nlattr *nla, case htons(ETH_P_8021AD): break; default: + if (exists) + tcf_idr_release(*a, bind); return -EPROTONOSUPPORT; } } else { |