diff options
| author |   Li Zefan <lizf@cn.fujitsu.com> | 2009-05-12 10:47:33 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-05-17 11:59:48 -0700 |
| commit | cb1c4b71f6da18fa98bab4af055f391d01bee8ba (patch) | |
| tree | 930bdf761d1dfa6a6ef4732866378f3fb37ad5bd /net/sched/cls_cgroup.c | |
| parent | net: remove needless (now buggy) & from dev->dev_addr (diff) | |
| download | linux-dev-cb1c4b71f6da18fa98bab4af055f391d01bee8ba.tar.xz linux-dev-cb1c4b71f6da18fa98bab4af055f391d01bee8ba.zip | |
cls_cgroup: remove unneeded cgroup_lock
We can remove this lock here, since we are in cgroup write handler and
thus the cgrp is guaranteed to be valid, and no lock is needed when
writing a u32 variable.
Signed-off-by: Li Zefan <lizf@cn.fujitsuc.com>
Acked-by: Paul Menage <menage@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_cgroup.c')
| -rw-r--r-- | net/sched/cls_cgroup.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c index 91a3db4a76f8..1ab4542e61e0 100644 --- a/net/sched/cls_cgroup.c +++ b/net/sched/cls_cgroup.c @@ -62,13 +62,7 @@ static u64 read_classid(struct cgroup *cgrp, struct cftype *cft) static int write_classid(struct cgroup *cgrp, struct cftype *cft, u64 value) { - if (!cgroup_lock_live_group(cgrp)) - return -ENODEV; - cgrp_cls_state(cgrp)->classid = (u32) value; - - cgroup_unlock(); - return 0; } |