diff options
| author |   Cong Wang <xiyou.wangcong@gmail.com> | 2017-10-13 11:58:53 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-16 21:02:54 +0100 |
| commit | 0ad646c81b2182f7fa67ec0c8c825e0ee165696d (patch) | |
| tree | 82aef9de787aa5f334a4802314385d8e8e443138 /net/sched/cls_flower.c | |
| parent | net: enable interface alias removal via rtnl (diff) | |
| download | linux-dev-0ad646c81b2182f7fa67ec0c8c825e0ee165696d.tar.xz linux-dev-0ad646c81b2182f7fa67ec0c8c825e0ee165696d.zip | |
tun: call dev_get_valid_name() before register_netdevice()
register_netdevice() could fail early when we have an invalid
dev name, in which case ->ndo_uninit() is not called. For tun
device, this is a problem because a timer etc. are already
initialized and it expects ->ndo_uninit() to clean them up.
We could move these initializations into a ->ndo_init() so
that register_netdevice() knows better, however this is still
complicated due to the logic in tun_detach().
Therefore, I choose to just call dev_get_valid_name() before
register_netdevice(), which is quicker and much easier to audit.
And for this specific case, it is already enough.
Fixes: 96442e42429e ("tuntap: choose the txq based on rxq")
Reported-by: Dmitry Alexeev <avekceeb@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/cls_flower.c')
0 files changed, 0 insertions, 0 deletions