diff options
| author |   Du Cheng <ducheng2@gmail.com> | 2021-04-17 07:30:46 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-04-19 15:29:07 -0700 |
| commit | ed8157f1ebf1ae81a8fa2653e3f20d2076fad1c9 (patch) | |
| tree | af6b26a9186618cd53a1bf9cd6f42beb5a765eca /net/sched/sch_taprio.c | |
| parent | vsock/vmci: log once the failed queue pair allocation (diff) | |
| download | linux-dev-ed8157f1ebf1ae81a8fa2653e3f20d2076fad1c9.tar.xz linux-dev-ed8157f1ebf1ae81a8fa2653e3f20d2076fad1c9.zip | |
net: sched: tapr: prevent cycle_time == 0 in parse_taprio_schedule
There is a reproducible sequence from the userland that will trigger a WARN_ON()
condition in taprio_get_start_time, which causes kernel to panic if configured
as "panic_on_warn". Catch this condition in parse_taprio_schedule to
prevent this condition.
Reported as bug on syzkaller:
https://syzkaller.appspot.com/bug?extid=d50710fd0873a9c6b40c
Reported-by: syzbot+d50710fd0873a9c6b40c@syzkaller.appspotmail.com
Signed-off-by: Du Cheng <ducheng2@gmail.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_taprio.c')
| -rw-r--r-- | net/sched/sch_taprio.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 8287894541e3..909c798b7403 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -901,6 +901,12 @@ static int parse_taprio_schedule(struct taprio_sched *q, struct nlattr **tb, list_for_each_entry(entry, &new->entries, list) cycle = ktime_add_ns(cycle, entry->interval); + + if (!cycle) { + NL_SET_ERR_MSG(extack, "'cycle_time' can never be 0"); + return -EINVAL; + } + new->cycle_time = cycle; } |