diff options
| author |   Dan Carpenter <error27@gmail.com> | 2010-08-14 11:09:49 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2010-08-18 14:24:51 -0700 |
| commit | 00093fab980d0a8950a64bdf9e346d0497b9a7e4 (patch) | |
| tree | 4f222456af157773cbf32f9f06ea0169fbcf929e /net/sched | |
| parent | s2io: Update driver version (diff) | |
| download | linux-dev-00093fab980d0a8950a64bdf9e346d0497b9a7e4.tar.xz linux-dev-00093fab980d0a8950a64bdf9e346d0497b9a7e4.zip | |
net/sched: remove unneeded NULL check
There is no need to check "s". nla_data() doesn't return NULL. Also we
already dereferenced "s" at this point so it would have oopsed ealier if
it were NULL.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_api.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index 408eea7086aa..6fb3d41c0e41 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -360,7 +360,7 @@ static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt) tsize = nla_len(tb[TCA_STAB_DATA]) / sizeof(u16); } - if (!s || tsize != s->tsize || (!tab && tsize > 0)) + if (tsize != s->tsize || (!tab && tsize > 0)) return ERR_PTR(-EINVAL); spin_lock(&qdisc_stab_lock); |