diff options
| author |   Vladimir Oltean <olteanv@gmail.com> | 2019-09-29 02:39:48 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-10-01 09:51:39 -0700 |
| commit | 83c8c3cf45163f0c823db37be6ab04dfcf8ac751 (patch) | |
| tree | 539bcbc710c0ab376da104a69db2a2f73093fbe6 /net/sched | |
| parent | net: sched: taprio: Avoid division by zero on invalid link speed (diff) | |
| download | linux-dev-83c8c3cf45163f0c823db37be6ab04dfcf8ac751.tar.xz linux-dev-83c8c3cf45163f0c823db37be6ab04dfcf8ac751.zip | |
net: sched: cbs: Avoid division by zero when calculating the port rate
As explained in the "net: sched: taprio: Avoid division by zero on
invalid link speed" commit, it is legal for the ethtool API to return
zero as a link speed. So guard against it to ensure we don't perform a
division by zero in kernel.
Fixes: e0a7683d30e9 ("net/sched: cbs: fix port_rate miscalculation")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_cbs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_cbs.c b/net/sched/sch_cbs.c index 1bef152c5721..b2905b03a432 100644 --- a/net/sched/sch_cbs.c +++ b/net/sched/sch_cbs.c @@ -306,7 +306,7 @@ static void cbs_set_port_rate(struct net_device *dev, struct cbs_sched_data *q) if (err < 0) goto skip; - if (ecmd.base.speed != SPEED_UNKNOWN) + if (ecmd.base.speed && ecmd.base.speed != SPEED_UNKNOWN) speed = ecmd.base.speed; skip: |