diff options
| author |   Patrick McHardy <kaber@trash.net> | 2007-03-29 11:46:52 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2007-03-29 11:46:52 -0700 |
| commit | c01003c20563d1e75ec9828d21743919d2b43977 (patch) | |
| tree | 21cae8933e8a4908d8e8c24244a627bf0c997e77 /net/sched | |
| parent | [BNX2]: Fix link interrupt problem. (diff) | |
| download | linux-dev-c01003c20563d1e75ec9828d21743919d2b43977.tar.xz linux-dev-c01003c20563d1e75ec9828d21743919d2b43977.zip | |
[IFB]: Fix crash on input device removal
The input_device pointer is not refcounted, which means the device may
disappear while packets are queued, causing a crash when ifb passes packets
with a stale skb->dev pointer to netif_rx().
Fix by storing the interface index instead and do a lookup where neccessary.
Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/act_mirred.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 68f26cb278f9..3e93683e9ab3 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred.c @@ -198,7 +198,7 @@ bad_mirred: skb2->tc_verd = SET_TC_FROM(skb2->tc_verd, at); skb2->dev = dev; - skb2->input_dev = skb->dev; + skb2->iif = skb->dev->ifindex; dev_queue_xmit(skb2); spin_unlock(&m->tcf_lock); return m->tcf_action; |