diff options
| author |   Haimin Zhang <tcs_kernel@tencent.com> | 2021-08-30 11:47:01 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-08-30 12:24:40 +0100 |
| commit | efe487fce3061d94222c6501d7be3aa549b3dc78 (patch) | |
| tree | 9736bad5c6d1a10fbf167ba9a94f0d7001a3e17e /net/sched | |
| parent | net: fix NULL pointer reference in cipso_v4_doi_free (diff) | |
| download | linux-dev-efe487fce3061d94222c6501d7be3aa549b3dc78.tar.xz linux-dev-efe487fce3061d94222c6501d7be3aa549b3dc78.zip | |
fix array-index-out-of-bounds in taprio_change
syzbot report an array-index-out-of-bounds in taprio_change
index 16 is out of range for type '__u16 [16]'
that's because mqprio->num_tc is lager than TC_MAX_QUEUE,so we check
the return value of netdev_set_num_tc.
Reported-by: syzbot+2b3e5fb6c7ef285a94f6@syzkaller.appspotmail.com
Signed-off-by: Haimin Zhang <tcs_kernel@tencent.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
| -rw-r--r-- | net/sched/sch_taprio.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sched/sch_taprio.c b/net/sched/sch_taprio.c index 9c79374457a0..1ab2fc933a21 100644 --- a/net/sched/sch_taprio.c +++ b/net/sched/sch_taprio.c @@ -1513,7 +1513,9 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt, taprio_set_picos_per_byte(dev, q); if (mqprio) { - netdev_set_num_tc(dev, mqprio->num_tc); + err = netdev_set_num_tc(dev, mqprio->num_tc); + if (err) + goto free_sched; for (i = 0; i < mqprio->num_tc; i++) netdev_set_tc_queue(dev, i, mqprio->count[i], |