diff options
| author |   Cong Wang <cwang@twopensource.com> | 2014-02-11 15:51:30 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-02-13 17:08:29 -0500 |
| commit | 0e0eee2465df77bcec2e8ff75432b8e57897b143 (patch) | |
| tree | 8d0728743356a1f524b6f88f09a1b09016d56190 /net/sctp | |
| parent | macvlan: unregister net device when netdev_upper_dev_link() fails (diff) | |
| download | linux-dev-0e0eee2465df77bcec2e8ff75432b8e57897b143.tar.xz linux-dev-0e0eee2465df77bcec2e8ff75432b8e57897b143.zip | |
net: correct error path in rtnl_newlink()
I saw the following BUG when ->newlink() fails in rtnl_newlink():
[ 40.240058] kernel BUG at net/core/dev.c:6438!
this is due to free_netdev() is not supposed to be called before
netdev is completely unregistered, therefore it is not correct
to call free_netdev() here, at least for ops->newlink!=NULL case,
many drivers call it in ->destructor so that rtnl_unlock() will
take care of it, we probably don't need to do anything here.
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
0 files changed, 0 insertions, 0 deletions