diff options
| author |   Xin Long <lucien.xin@gmail.com> | 2021-10-20 07:42:47 -0400 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-10-22 12:36:45 -0700 |
| commit | 9d02831e517aa36ee6bdb453a0eb47bd49923fe3 (patch) | |
| tree | f738b398b18ee76fbc89ed024c09cc2e8825c0b5 /net/sctp | |
| parent | sctp: add vtag check in sctp_sf_do_8_5_1_E_sa (diff) | |
| download | linux-dev-9d02831e517aa36ee6bdb453a0eb47bd49923fe3.tar.xz linux-dev-9d02831e517aa36ee6bdb453a0eb47bd49923fe3.zip | |
sctp: add vtag check in sctp_sf_ootb
sctp_sf_ootb() is called when processing DATA chunk in closed state,
and many other places are also using it.
The vtag in the chunk's sctphdr should be verified, otherwise, as
later in chunk length check, it may send abort with the existent
asoc's vtag, which can be exploited by one to cook a malicious
chunk to terminate a SCTP asoc.
When fails to verify the vtag from the chunk, this patch sets asoc
to NULL, so that the abort will be made with the vtag from the
received chunk later.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/sm_statefuns.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index a3545498a038..fb3da4d8f4a3 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -3688,6 +3688,9 @@ enum sctp_disposition sctp_sf_ootb(struct net *net, SCTP_INC_STATS(net, SCTP_MIB_OUTOFBLUES); + if (asoc && !sctp_vtag_verify(chunk, asoc)) + asoc = NULL; + ch = (struct sctp_chunkhdr *)chunk->chunk_hdr; do { /* Report violation if the chunk is less then minimal */ |