diff options
| author |   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2021-06-28 16:13:43 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-28 15:34:50 -0700 |
| commit | b6ffe7671b24689c09faa5675dd58f93758a97ae (patch) | |
| tree | 8e4a9acc78883f45e75b57cb59e74c8f80e5e653 /net/sctp | |
| parent | sctp: add size validation when walking chunks (diff) | |
| download | linux-dev-b6ffe7671b24689c09faa5675dd58f93758a97ae.tar.xz linux-dev-b6ffe7671b24689c09faa5675dd58f93758a97ae.zip | |
sctp: validate chunk size in __rcv_asconf_lookup
In one of the fallbacks that SCTP has for identifying an association for an
incoming packet, it looks for AddIp chunk (from ASCONF) and take a peek.
Thing is, at this stage nothing was validating that the chunk actually had
enough content for that, allowing the peek to happen over uninitialized
memory.
Similar check already exists in actual asconf handling in
sctp_verify_asconf().
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/input.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sctp/input.c b/net/sctp/input.c index f72bff93745c..96dea8097dbe 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c @@ -1168,6 +1168,9 @@ static struct sctp_association *__sctp_rcv_asconf_lookup( union sctp_addr_param *param; union sctp_addr paddr; + if (ntohs(ch->length) < sizeof(*asconf) + sizeof(struct sctp_paramhdr)) + return NULL; + /* Skip over the ADDIP header and find the Address parameter */ param = (union sctp_addr_param *)(asconf + 1); |