diff options
| author |   Alexey Khoroshilov <khoroshilov@ispras.ru> | 2021-11-05 20:30:27 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-11-07 19:32:39 +0000 |
| commit | e7ea51cd879c8214a824717d28a169b5f2262c02 (patch) | |
| tree | 9765f08f40624ef336b98d41cc9328de2319c8c9 /net/sctp | |
| parent | llc: fix out-of-bound array index in llc_sk_dev_hash() (diff) | |
| download | linux-dev-e7ea51cd879c8214a824717d28a169b5f2262c02.tar.xz linux-dev-e7ea51cd879c8214a824717d28a169b5f2262c02.zip | |
sctp: remove unreachable code from sctp_sf_violation_chunk()
sctp_sf_violation_chunk() is not called with asoc argument equal to NULL,
but if that happens it would lead to NULL pointer dereference
in sctp_vtag_verify().
The patch removes code that handles NULL asoc in sctp_sf_violation_chunk().
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Proposed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/sm_statefuns.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index 5fabaa54b77d..39ba82ee87ce 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -4898,9 +4898,6 @@ static enum sctp_disposition sctp_sf_violation_chunk( { static const char err_str[] = "The following chunk violates protocol:"; - if (!asoc) - return sctp_sf_violation(net, ep, asoc, type, arg, commands); - return sctp_sf_abort_violation(net, ep, asoc, arg, commands, err_str, sizeof(err_str)); } |