diff options
| author |   J. Bruce Fields <bfields@redhat.com> | 2021-07-01 20:06:56 -0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2021-07-06 20:14:44 -0400 |
| commit | ab1016d39cc052064e32f25ad18ef8767a0ee3b8 (patch) | |
| tree | 7dd5b888b9dd16399cbc36b9c3d9eb980f19d342 /net/sunrpc/xprtrdma | |
| parent | NFSD: Prevent a possible oops in the nfs_dirent() tracepoint (diff) | |
| download | linux-dev-ab1016d39cc052064e32f25ad18ef8767a0ee3b8.tar.xz linux-dev-ab1016d39cc052064e32f25ad18ef8767a0ee3b8.zip | |
nfsd: fix NULL dereference in nfs3svc_encode_getaclres
In error cases the dentry may be NULL.
Before 20798dfe249a, the encoder also checked dentry and
d_really_is_positive(dentry), but that looks like overkill to me--zero
status should be enough to guarantee a positive dentry.
This isn't the first time we've seen an error-case NULL dereference
hidden in the initialization of a local variable in an xdr encoder. But
I went back through the other recent rewrites and didn't spot any
similar bugs.
Reported-by: JianHong Yin <jiyin@redhat.com>
Reviewed-by: Chuck Lever III <chuck.lever@oracle.com>
Fixes: 20798dfe249a ("NFSD: Update the NFSv3 GETACL result encoder...")
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'net/sunrpc/xprtrdma')
0 files changed, 0 insertions, 0 deletions