diff options
| author |   Chuck Lever <chuck.lever@oracle.com> | 2017-12-14 20:56:18 -0500 |
|---|---|---|
| committer |   Anna Schumaker <Anna.Schumaker@Netapp.com> | 2018-01-16 11:19:42 -0500 |
| commit | 42b9f5c58aa8c59c91ead0254f0c193e3438b020 (patch) | |
| tree | 09913cced38a56763951c91023d94d5e381c4154 /net/sunrpc | |
| parent | xprtrdma: Fix backchannel allocation of extra rpcrdma_reps (diff) | |
| download | linux-dev-42b9f5c58aa8c59c91ead0254f0c193e3438b020.tar.xz linux-dev-42b9f5c58aa8c59c91ead0254f0c193e3438b020.zip | |
xprtrdma: Eliminate unnecessary lock cycle in xprt_rdma_send_request
The rpcrdma_req is not shared yet, and its associated Send hasn't
been posted, thus RMW should be safe. There's no need for the
expense of a lock cycle here.
Fixes: 0ba6f37012db ("xprtrdma: Refactor rpcrdma_deferred_completion")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/xprtrdma/transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index 7f9b62822807..7db063f8dd8a 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -735,7 +735,7 @@ xprt_rdma_send_request(struct rpc_task *task) goto drop_connection; req->rl_connect_cookie = xprt->connect_cookie; - set_bit(RPCRDMA_REQ_F_PENDING, &req->rl_flags); + __set_bit(RPCRDMA_REQ_F_PENDING, &req->rl_flags); if (rpcrdma_ep_post(&r_xprt->rx_ia, &r_xprt->rx_ep, req)) goto drop_connection; |