diff options
author | 2014-04-28 18:00:10 +0800 | |
---|---|---|
committer | 2014-04-28 14:49:54 -0400 | |
commit | eab8c045732635e3833a5d58b17c6da08ff71f9e (patch) | |
tree | 8bd9c3e5aaee575abef950d992e92511bdc5f2b8 /net/tipc/node.h | |
parent | tipc: fix out of bounds indexing (diff) | |
download | linux-dev-eab8c045732635e3833a5d58b17c6da08ff71f9e.tar.xz linux-dev-eab8c045732635e3833a5d58b17c6da08ff71f9e.zip |
tipc: move the delivery of named messages out of nametbl lock
Commit a89778d8baf19cd7e728d81121a294a06cedaad1 ("tipc: add support
for link state subscriptions") introduced below possible deadlock
scenario:
CPU0 CPU1
T0: tipc_publish() link_timeout()
T1: tipc_nametbl_publish() [grab node lock]*
T2: [grab nametbl write lock]* link_state_event()
T3: named_cluster_distribute() link_activate()
T4: [grab node lock]* tipc_node_link_up()
T5: tipc_nametbl_publish()
T6: [grab nametble write lock]*
The opposite order of holding nametbl write lock and node lock on
above two different paths may result in a deadlock. If we move the
the delivery of named messages via link out of name nametbl lock,
the reverse order of holding locks will be eliminated, as a result,
the deadlock will be killed as well.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Reviewed-by: Erik Hugne <erik.hugne@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/node.h')
0 files changed, 0 insertions, 0 deletions