diff options
| author |   Guoqing Jiang <gqjiang@suse.com> | 2018-10-19 12:08:22 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-10-22 19:25:32 -0700 |
| commit | 29e270fc32192e7729057963ae7120663856c93e (patch) | |
| tree | 2d0c82a21d7fd117bef62e8f17b357f9ab59f0a9 /net/tipc | |
| parent | isdn: hfc_{pci,sx}: Avoid empty body if statements (diff) | |
| download | linux-dev-29e270fc32192e7729057963ae7120663856c93e.tar.xz linux-dev-29e270fc32192e7729057963ae7120663856c93e.zip | |
tipc: use destination length for copy string
Got below warning with gcc 8.2 compiler.
net/tipc/topsrv.c: In function ‘tipc_topsrv_start’:
net/tipc/topsrv.c:660:2: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
strncpy(srv->name, name, strlen(name) + 1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/tipc/topsrv.c:660:27: note: length computed here
strncpy(srv->name, name, strlen(name) + 1);
^~~~~~~~~~~~
So change it to correct length and use strscpy.
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
| -rw-r--r-- | net/tipc/topsrv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c index d8956f7daac4..4bdea0057171 100644 --- a/net/tipc/topsrv.c +++ b/net/tipc/topsrv.c @@ -651,7 +651,7 @@ int tipc_topsrv_start(struct net *net) srv->max_rcvbuf_size = sizeof(struct tipc_subscr); INIT_WORK(&srv->awork, tipc_topsrv_accept); - strncpy(srv->name, name, strlen(name) + 1); + strscpy(srv->name, name, sizeof(srv->name)); tn->topsrv = srv; atomic_set(&tn->subscription_count, 0); |