diff options
| author |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-05-21 19:02:02 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-05-22 12:21:44 -0700 |
| commit | c3f4a6c39cf269a40d45f813c05fa830318ad875 (patch) | |
| tree | 752d5cfd6c2b21e9b7e5e2f3b035940db70e4086 /net/tls | |
| parent | net/tls: fix state removal with feature flags off (diff) | |
| download | linux-dev-c3f4a6c39cf269a40d45f813c05fa830318ad875.tar.xz linux-dev-c3f4a6c39cf269a40d45f813c05fa830318ad875.zip | |
net/tls: don't ignore netdev notifications if no TLS features
On device surprise removal path (the notifier) we can't
bail just because the features are disabled. They may
have been enabled during the lifetime of the device.
This bug leads to leaking netdev references and
use-after-frees if there are active connections while
device features are cleared.
Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls')
| -rw-r--r-- | net/tls/tls_device.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 07650446e892..b95c408fd771 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -997,7 +997,8 @@ static int tls_dev_event(struct notifier_block *this, unsigned long event, { struct net_device *dev = netdev_notifier_info_to_dev(ptr); - if (!(dev->features & (NETIF_F_HW_TLS_RX | NETIF_F_HW_TLS_TX))) + if (!dev->tlsdev_ops && + !(dev->features & (NETIF_F_HW_TLS_RX | NETIF_F_HW_TLS_TX))) return NOTIFY_DONE; switch (event) { |