diff options
| author |   Pan Bian <bianpan2016@163.com> | 2019-11-07 14:29:50 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-07 15:23:19 -0800 |
| commit | 025ec40b81d785a98f76b8bdb509ac10773b4f12 (patch) | |
| tree | d4f6cf258ea7563442aaa75d9d697d4b45690d58 /net | |
| parent | NFC: st21nfca: fix double free (diff) | |
| download | linux-dev-025ec40b81d785a98f76b8bdb509ac10773b4f12.tar.xz linux-dev-025ec40b81d785a98f76b8bdb509ac10773b4f12.zip | |
nfc: netlink: fix double device reference drop
The function nfc_put_device(dev) is called twice to drop the reference
to dev when there is no associated local llcp. Remove one of them to fix
the bug.
Fixes: 52feb444a903 ("NFC: Extend netlink interface for LTO, RW, and MIUX parameters support")
Fixes: d9b8d8e19b07 ("NFC: llcp: Service Name Lookup netlink interface")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/nfc/netlink.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 17e6ca62f1be..afde0d763039 100644 --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -1099,7 +1099,6 @@ static int nfc_genl_llc_set_params(struct sk_buff *skb, struct genl_info *info) local = nfc_llcp_find_local(dev); if (!local) { - nfc_put_device(dev); rc = -ENODEV; goto exit; } @@ -1159,7 +1158,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info) local = nfc_llcp_find_local(dev); if (!local) { - nfc_put_device(dev); rc = -ENODEV; goto exit; } |