diff options
| author |   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2016-03-18 18:39:18 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-03-20 16:31:11 -0400 |
| commit | 07b4d6a1749422fa1e054f3c2aba444acdba39e8 (patch) | |
| tree | 6474dfe18a02acadb6a3fee23d2719af33601202 /net | |
| parent | net: remove a dubious unlikely() clause (diff) | |
| download | linux-dev-07b4d6a1749422fa1e054f3c2aba444acdba39e8.tar.xz linux-dev-07b4d6a1749422fa1e054f3c2aba444acdba39e8.zip | |
sctp: do not update a_rwnd if we are not issuing a sack
The SACK can be lost pretty much elsewhere, but if its allocation fail,
we know we are not sending it, so it is better to revert a_rwnd to its
previous value as this may give it a chance to issue a window update
later.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/sm_sideeffect.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c index 3c22c41a2bc2..7fe56d0acabf 100644 --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c @@ -215,10 +215,14 @@ static int sctp_gen_sack(struct sctp_association *asoc, int force, sctp_add_cmd_sf(commands, SCTP_CMD_TIMER_RESTART, SCTP_TO(SCTP_EVENT_TIMEOUT_SACK)); } else { + __u32 old_a_rwnd = asoc->a_rwnd; + asoc->a_rwnd = asoc->rwnd; sack = sctp_make_sack(asoc); - if (!sack) + if (!sack) { + asoc->a_rwnd = old_a_rwnd; goto nomem; + } asoc->peer.sack_needed = 0; asoc->peer.sack_cnt = 0; |