diff options
| author |   MichelleJin <shjy180909@gmail.com> | 2021-09-27 03:34:57 +0000 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2021-09-27 12:00:34 +0200 |
| commit | 111461d573741c17eafad029ac93474fa9adcce0 (patch) | |
| tree | b543ca397a347e10a4e42eac77f04280c395b793 /net | |
| parent | mac80211: fix use-after-free in CCMP/GCMP RX (diff) | |
| download | linux-dev-111461d573741c17eafad029ac93474fa9adcce0.tar.xz linux-dev-111461d573741c17eafad029ac93474fa9adcce0.zip | |
mac80211: check return value of rhashtable_init
When rhashtable_init() fails, it returns -EINVAL.
However, since error return value of rhashtable_init is not checked,
it can cause use of uninitialized pointers.
So, fix unhandled errors of rhashtable_init.
Signed-off-by: MichelleJin <shjy180909@gmail.com>
Link: https://lore.kernel.org/r/20210927033457.1020967-4-shjy180909@gmail.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mac80211/mesh_pathtbl.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c index efbefcbac3ac..7cab1cf09bf1 100644 --- a/net/mac80211/mesh_pathtbl.c +++ b/net/mac80211/mesh_pathtbl.c @@ -60,7 +60,10 @@ static struct mesh_table *mesh_table_alloc(void) atomic_set(&newtbl->entries, 0); spin_lock_init(&newtbl->gates_lock); spin_lock_init(&newtbl->walk_lock); - rhashtable_init(&newtbl->rhead, &mesh_rht_params); + if (rhashtable_init(&newtbl->rhead, &mesh_rht_params)) { + kfree(newtbl); + return NULL; + } return newtbl; } |