diff options
| author |   Ivan Vecera <ivecera@redhat.com> | 2009-02-06 21:49:57 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2009-02-06 21:49:57 -0800 |
| commit | 355423d0849f4506bc71ab2738d38cb74429aaef (patch) | |
| tree | efed57e98981e928f91c239075e4ed4bea5385ec /net | |
| parent | udp: Fix potential wrong ip_hdr(skb) pointers (diff) | |
| download | linux-dev-355423d0849f4506bc71ab2738d38cb74429aaef.tar.xz linux-dev-355423d0849f4506bc71ab2738d38cb74429aaef.zip | |
r8169: Don't update statistics counters when interface is down
Some Realtek chips (RTL8169sb/8110sb in my case) are unable to retrieve
ethtool statistics when the interface is down. The process stays in
endless loop in rtl8169_get_ethtool_stats. This is because these chips
need to have receiver enabled (CmdRxEnb bit in ChipCmd register) that is
cleared when the interface is going down. It's better to update statistics
only when the interface is up and otherwise return copy of statistics
grabbed when the interface was up (in rtl8169_close).
It is interesting that PCI-E NICs (like 8168b/8111b...) are not affected.
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions