diff options
| author |   Masahiro Yamada <masahiroy@kernel.org> | 2022-06-06 13:53:55 +0900 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-06-08 10:10:14 -0700 |
| commit | 5801f064e35181c71857a80ff18af4dbec3c5f5c (patch) | |
| tree | f1b401ed37a3365a641fb10bc6626d972a377ad3 /net | |
| parent | net: xfrm: unexport __init-annotated xfrm4_protocol_init() (diff) | |
| download | linux-dev-5801f064e35181c71857a80ff18af4dbec3c5f5c.tar.xz linux-dev-5801f064e35181c71857a80ff18af4dbec3c5f5c.zip | |
net: ipv6: unexport __init-annotated seg6_hmac_init()
EXPORT_SYMBOL and __init is a bad combination because the .init.text
section is freed up after the initialization. Hence, modules cannot
use symbols annotated __init. The access to a freed symbol may end up
with kernel panic.
modpost used to detect it, but it has been broken for a decade.
Recently, I fixed modpost so it started to warn it again, then this
showed up in linux-next builds.
There are two ways to fix it:
- Remove __init
- Remove EXPORT_SYMBOL
I chose the latter for this case because the caller (net/ipv6/seg6.c)
and the callee (net/ipv6/seg6_hmac.c) belong to the same module.
It seems an internal function call in ipv6.ko.
Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/seg6_hmac.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/seg6_hmac.c b/net/ipv6/seg6_hmac.c index 29bc4e7c3046..6de01185cc68 100644 --- a/net/ipv6/seg6_hmac.c +++ b/net/ipv6/seg6_hmac.c @@ -399,7 +399,6 @@ int __init seg6_hmac_init(void) { return seg6_hmac_init_algo(); } -EXPORT_SYMBOL(seg6_hmac_init); int __net_init seg6_hmac_net_init(struct net *net) { |