diff options
| author |   Ben Hutchings <bhutchings@solarflare.com> | 2013-07-04 23:48:46 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-07-05 01:29:15 -0700 |
| commit | 734d4e159b283a4ae4d007b7e7a91d84398ccb92 (patch) | |
| tree | 410ed812608383a8e88ffe16cc228be20bf2240b /net | |
| parent | sit: fix tunnel update via netlink (diff) | |
| download | linux-dev-734d4e159b283a4ae4d007b7e7a91d84398ccb92.tar.xz linux-dev-734d4e159b283a4ae4d007b7e7a91d84398ccb92.zip | |
sfc: Fix memory leak when discarding scattered packets
Commit 2768935a4660 ('sfc: reuse pages to avoid DMA mapping/unmapping
costs') did not fully take account of DMA scattering which was
introduced immediately before. If a received packet is invalid and
must be discarded, we only drop a reference to the first buffer's
page, but we need to drop a reference for each buffer the packet
used.
I think this bug was missed partly because efx_recycle_rx_buffers()
was not renamed and so no longer does what its name says. It does not
change the state of buffers, but only prepares the underlying pages
for recycling. Rename it accordingly.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions