aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorSteffen Klassert <steffen.klassert@secunet.com>2019-11-06 08:13:49 +0100
committerSteffen Klassert <steffen.klassert@secunet.com>2019-11-07 10:38:07 +0100
commit86c6739eda7d2a03f2db30cbee67a5fb81afa8ba (patch)
tree2bf5a1081ccd62010fa98aa52e67ced8becd44b4 /net
parentNFC: st21nfca: fix double free (diff)
downloadlinux-dev-86c6739eda7d2a03f2db30cbee67a5fb81afa8ba.tar.xz
linux-dev-86c6739eda7d2a03f2db30cbee67a5fb81afa8ba.zip
xfrm: Fix memleak on xfrm state destroy
We leak the page that we use to create skb page fragments when destroying the xfrm_state. Fix this by dropping a page reference if a page was assigned to the xfrm_state. Fixes: cac2661c53f3 ("esp4: Avoid skb_cow_data whenever possible") Reported-by: JD <jdtxs00@gmail.com> Reported-by: Paul Wouters <paul@nohats.ca> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net')
-rw-r--r--net/xfrm/xfrm_state.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index c6f3c4a1bd99..f3423562d933 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -495,6 +495,8 @@ static void ___xfrm_state_destroy(struct xfrm_state *x)
x->type->destructor(x);
xfrm_put_type(x->type);
}
+ if (x->xfrag.page)
+ put_page(x->xfrag.page);
xfrm_dev_state_free(x);
security_xfrm_state_free(x);
xfrm_state_free(x);