aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorRobert Jarzmik <robert.jarzmik@free.fr>2015-02-12 17:59:10 +0100
committerDavid S. Miller <davem@davemloft.net>2015-03-17 15:04:57 -0400
commit8d7d9cca4390062ccd09ffd9fdb37d1c4eeea9ac (patch)
treee13d853c739413609ef11a9d24a21b0ace04a0c2 /net
parentinet: Clean up inet_csk_wait_for_connect() vs. might_sleep() (diff)
downloadlinux-dev-8d7d9cca4390062ccd09ffd9fdb37d1c4eeea9ac.tar.xz
linux-dev-8d7d9cca4390062ccd09ffd9fdb37d1c4eeea9ac.zip
Revert "smc91x: retrieve IRQ and trigger flags in a modern way"
The commit breaks the legacy platforms, ie. these not using device-tree, and setting up the interrupt resources with a flag to activate edge detection. The issue was found on the zylonite platform. The reason is that zylonite uses platform resources to pass the interrupt number and the irq flags (here IORESOURCE_IRQ_HIGHEDGE). It expects the driver to request the irq with these flags, which in turn setups the irq as high edge triggered. After the patch, this was supposed to be taken care of with : irq_resflags = irqd_get_trigger_type(irq_get_irq_data(ndev->irq)); But irq_resflags is 0 for legacy platforms, while for example in arch/arm/mach-pxa/zylonite.c, in struct resource smc91x_resources[] the irq flag is specified. This breaks zylonite because the interrupt is not setup as triggered, and hardware doesn't provide interrupts. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions