diff options
| author |   Maxim Mikityanskiy <maximmi@mellanox.com> | 2019-02-22 12:55:22 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-02-24 12:40:38 -0800 |
| commit | a0dce8752193ee314c8dcff8671aa0a0cea4d377 (patch) | |
| tree | 5a375aedf891031897c73aa0492a346d15cf9152 /net | |
| parent | doc: add phylink documentation to the networking book (diff) | |
| download | linux-dev-a0dce8752193ee314c8dcff8671aa0a0cea4d377.tar.xz linux-dev-a0dce8752193ee314c8dcff8671aa0a0cea4d377.zip | |
net: Skip GSO length estimation if transport header is not set
qdisc_pkt_len_init expects transport_header to be set for GSO packets.
Patch [1] skips transport_header validation for GSO packets that don't
have network_header set at the moment of calling virtio_net_hdr_to_skb,
and allows them to pass into the stack. After patch [2] no placeholder
value is assigned to transport_header if dissection fails, so this patch
adds a check to the place where the value of transport_header is used.
[1] https://patchwork.ozlabs.org/patch/1044429/
[2] https://patchwork.ozlabs.org/patch/1046122/
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index a3d13f5e2bfc..8a0da95ff4cc 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3421,7 +3421,7 @@ static void qdisc_pkt_len_init(struct sk_buff *skb) /* To get more precise estimation of bytes sent on wire, * we add to pkt_len the headers size of all segments */ - if (shinfo->gso_size) { + if (shinfo->gso_size && skb_transport_header_was_set(skb)) { unsigned int hdr_len; u16 gso_segs = shinfo->gso_segs; |