diff options
| author |   Bart Van Assche <bvanassche@acm.org> | 2019-03-25 09:17:20 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-27 13:49:43 -0700 |
| commit | b3c0fd61e6ab0bf7381b31cb4edef76e2ec2f2bf (patch) | |
| tree | c62c42730ee3b733a3204b7fa863c218451fc11a /net | |
| parent | net/core: Document reuseport_add_sock() bind_inany argument (diff) | |
| download | linux-dev-b3c0fd61e6ab0bf7381b31cb4edef76e2ec2f2bf.tar.xz linux-dev-b3c0fd61e6ab0bf7381b31cb4edef76e2ec2f2bf.zip | |
net/core: Document all dev_ioctl() arguments
This patch avoids that the following warnings are reported when building
with W=1:
net/core/dev_ioctl.c:378: warning: Function parameter or member 'ifr' not described in 'dev_ioctl'
net/core/dev_ioctl.c:378: warning: Function parameter or member 'need_copyout' not described in 'dev_ioctl'
net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl'
Cc: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 44c02a2c3dc5 ("dev_ioctl(): move copyin/copyout to callers") # v4.16.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/dev_ioctl.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 31380fd5a4e2..5163d900bb4f 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -366,7 +366,8 @@ EXPORT_SYMBOL(dev_load); * dev_ioctl - network device ioctl * @net: the applicable net namespace * @cmd: command to issue - * @arg: pointer to a struct ifreq in user space + * @ifr: pointer to a struct ifreq in user space + * @need_copyout: whether or not copy_to_user() should be called * * Issue ioctl functions to devices. This is normally called by the * user space syscall interfaces but can sometimes be useful for |