diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-09-18 08:05:39 -0700 |
|---|---|---|
| committer |   Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-09-20 19:12:22 -0700 |
| commit | b41d936b5ecfdb3a4abc525ce6402a6c49cffddc (patch) | |
| tree | 240877850aa857e1f58e6a4be373c2ecee883f20 /net | |
| parent | dt-bindings: net: remove un-implemented property (diff) | |
| download | linux-dev-b41d936b5ecfdb3a4abc525ce6402a6c49cffddc.tar.xz linux-dev-b41d936b5ecfdb3a4abc525ce6402a6c49cffddc.zip | |
sch_netem: fix a divide by zero in tabledist()
syzbot managed to crash the kernel in tabledist() loading
an empty distribution table.
t = dist->table[rnd % dist->size];
Simply return an error when such load is attempted.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sched/sch_netem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index b17f2ed970e2..f5cb35e550f8 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -777,7 +777,7 @@ static int get_dist_table(struct Qdisc *sch, struct disttable **tbl, struct disttable *d; int i; - if (n > NETEM_DIST_MAX) + if (!n || n > NETEM_DIST_MAX) return -EINVAL; d = kvmalloc(sizeof(struct disttable) + n * sizeof(s16), GFP_KERNEL); |