diff options
| author |   Chris J Arges <chris.j.arges@canonical.com> | 2015-07-21 12:36:33 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-07-21 22:26:03 -0700 |
| commit | bac541e46319c2dc6ff9fd5ad6df59cd38686bdb (patch) | |
| tree | 5b74b1805715747b98e38fe7bcbceef20dc0f420 /net | |
| parent | netlink: don't hold mutex in rcu callback when releasing mmapd ring (diff) | |
| download | linux-dev-bac541e46319c2dc6ff9fd5ad6df59cd38686bdb.tar.xz linux-dev-bac541e46319c2dc6ff9fd5ad6df59cd38686bdb.zip | |
openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes
Some architectures like POWER can have a NUMA node_possible_map that
contains sparse entries. This causes memory corruption with openvswitch
since it allocates flow_cache with a multiple of num_possible_nodes() and
assumes the node variable returned by for_each_node will index into
flow->stats[node].
Use nr_node_ids to allocate a maximal sparse array instead of
num_possible_nodes().
The crash was noticed after 3af229f2 was applied as it changed the
node_possible_map to match node_online_map on boot.
Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
Acked-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/openvswitch/flow_table.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c index 4613df8c8290..65523948fb95 100644 --- a/net/openvswitch/flow_table.c +++ b/net/openvswitch/flow_table.c @@ -752,7 +752,7 @@ int ovs_flow_init(void) BUILD_BUG_ON(sizeof(struct sw_flow_key) % sizeof(long)); flow_cache = kmem_cache_create("sw_flow", sizeof(struct sw_flow) - + (num_possible_nodes() + + (nr_node_ids * sizeof(struct flow_stats *)), 0, 0, NULL); if (flow_cache == NULL) |