diff options
| author |   Xin Long <lucien.xin@gmail.com> | 2016-05-26 03:09:23 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-05-25 22:14:31 -0700 |
| commit | bed187b540167eb10320f6a2177604421650772e (patch) | |
| tree | 53e185eb72e708916a3d3bfb66c1a9ce20223382 /net | |
| parent | net: arc: trivial: Replace comma with a semicolon (diff) | |
| download | linux-dev-bed187b540167eb10320f6a2177604421650772e.tar.xz linux-dev-bed187b540167eb10320f6a2177604421650772e.zip | |
sctp: fix double EPs display in sctp_diag
We have this situation: that EP hash table, contains only the EPs
that are listening, while the transports one, has the opposite.
We have to traverse both to dump all.
But when we traverse the transports one we will also get EPs that are
in the EP hash if they are listening. In this case, the EP is dumped
twice.
We will fix it by checking if the endpoint that is in the endpoint
hash table contains any ep->asoc in there, as it means we will also
find it via transport hash, and thus we can/should skip it, depending
on the filters used, like 'ss -l'.
Still, we should NOT skip it if the user is listing only listening
endpoints, because then we are not traversing the transport hash.
so we have to check idiag_states there also.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/sctp_diag.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c index 8e3e769dc9ea..1ce724b87618 100644 --- a/net/sctp/sctp_diag.c +++ b/net/sctp/sctp_diag.c @@ -356,6 +356,9 @@ static int sctp_ep_dump(struct sctp_endpoint *ep, void *p) if (cb->args[4] < cb->args[1]) goto next; + if ((r->idiag_states & ~TCPF_LISTEN) && !list_empty(&ep->asocs)) + goto next; + if (r->sdiag_family != AF_UNSPEC && sk->sk_family != r->sdiag_family) goto next; |