diff options
| author |   Sabrina Dubroca <sd@queasysnail.net> | 2014-10-21 11:08:21 +0200 |
|---|---|---|
| committer |   Pablo Neira Ayuso <pablo@netfilter.org> | 2014-10-22 14:12:51 +0200 |
| commit | c123bb7163043bb8f33858cf8e45b01c17dbd171 (patch) | |
| tree | 023d053dc015873ad17e6db1bdee08a190c4bba3 /net | |
| parent | netfilter: ipset: off by one in ip_set_nfnl_get_byindex() (diff) | |
| download | linux-dev-c123bb7163043bb8f33858cf8e45b01c17dbd171.tar.xz linux-dev-c123bb7163043bb8f33858cf8e45b01c17dbd171.zip | |
netfilter: nf_tables: check for NULL in nf_tables_newchain pcpu stats allocation
alloc_percpu returns NULL on failure, not a negative error code.
Fixes: ff3cd7b3c922 ("netfilter: nf_tables: refactor chain statistic routines")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 65eb2a1160d5..11ab4b078f3b 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -1328,10 +1328,10 @@ static int nf_tables_newchain(struct sock *nlsk, struct sk_buff *skb, basechain->stats = stats; } else { stats = netdev_alloc_pcpu_stats(struct nft_stats); - if (IS_ERR(stats)) { + if (stats == NULL) { module_put(type->owner); kfree(basechain); - return PTR_ERR(stats); + return -ENOMEM; } rcu_assign_pointer(basechain->stats, stats); } |