diff options
| author |   Rob Herring <rob.herring@calxeda.com> | 2013-08-30 16:49:24 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2013-09-03 22:21:15 -0400 |
| commit | cbe157b60c8e70d4b4dc937dfdd39525d8f47b46 (patch) | |
| tree | 8b60f94561cd4f481060bfc19b4e39a5e5a93bd1 /net | |
| parent | net: calxedaxgmac: update ring buffer tx_head after barriers (diff) | |
| download | linux-dev-cbe157b60c8e70d4b4dc937dfdd39525d8f47b46.tar.xz linux-dev-cbe157b60c8e70d4b4dc937dfdd39525d8f47b46.zip | |
net: calxedaxgmac: fix race with tx queue stop/wake
Since the xgmac transmit start and completion work locklessly, it is
possible for xgmac_xmit to stop the tx queue after the xgmac_tx_complete
has run resulting in the tx queue never being woken up. Fix this by
ensuring that ring buffer index updates are visible and recheck the ring
space after stopping the queue. Also fix an off-by-one bug where we need
to stop the queue when the ring buffer space is equal to MAX_SKB_FRAGS.
The implementation used here was copied from
drivers/net/ethernet/broadcom/tg3.c.
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions