aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDavid Ahern <dsahern@gmail.com>2019-03-27 20:53:51 -0700
committerDavid S. Miller <davem@davemloft.net>2019-03-29 10:48:03 -0700
commitdac7d0f27075ce54017a7efdd6ae0a55352a0f80 (patch)
tree1f2625e0a0afdf2efd4a150689a91610adcba873 /net
parentipv6: Create init helper for fib6_nh (diff)
downloadlinux-dev-dac7d0f27075ce54017a7efdd6ae0a55352a0f80.tar.xz
linux-dev-dac7d0f27075ce54017a7efdd6ae0a55352a0f80.zip
ipv6: Create cleanup helper for fib6_nh
Move the fib6_nh cleanup code to a new helper, fib6_nh_release. Signed-off-by: David Ahern <dsahern@gmail.com> Reviewed-by: Ido Schimmel <idosch@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv6/ip6_fib.c5
-rw-r--r--net/ipv6/route.c8
2 files changed, 9 insertions, 4 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 6613d8dbb0e5..db886085369b 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -199,10 +199,7 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
free_percpu(f6i->rt6i_pcpu);
}
- lwtstate_put(f6i->fib6_nh.nh_lwtstate);
-
- if (f6i->fib6_nh.nh_dev)
- dev_put(f6i->fib6_nh.nh_dev);
+ fib6_nh_release(&f6i->fib6_nh);
ip_fib_metrics_put(f6i->fib6_metrics);
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 8c5a998b28a1..5f453c79dd00 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3025,6 +3025,14 @@ out:
return err;
}
+void fib6_nh_release(struct fib6_nh *fib6_nh)
+{
+ lwtstate_put(fib6_nh->nh_lwtstate);
+
+ if (fib6_nh->nh_dev)
+ dev_put(fib6_nh->nh_dev);
+}
+
static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
gfp_t gfp_flags,
struct netlink_ext_ack *extack)