diff options
| author |   Julian Anastasov <ja@ssi.bg> | 2005-11-08 09:40:05 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2005-11-08 09:40:05 -0800 |
| commit | dc8103f25fd7cfac2c2b295f33edc10f255b4c80 (patch) | |
| tree | db09e8efee33d1e7d4527d81a3c1b0ece03cea33 /net | |
| parent | [NET]: sk_add_backlog convert from macro to inline (diff) | |
| download | linux-dev-dc8103f25fd7cfac2c2b295f33edc10f255b4c80.tar.xz linux-dev-dc8103f25fd7cfac2c2b295f33edc10f255b4c80.zip | |
[IPVS]: fix connection leak if expire_nodest_conn=1
There was a fix in 2.6.13 that changed the behaviour of
ip_vs_conn_expire_now function not to put reference to connection,
its callers should hold write lock or connection refcnt. But we
forgot to convert one caller, when the real server for connection
is unavailable caller should put the connection reference. It
happens only when sysctl var expire_nodest_conn is set to 1 and
such connections never expire. Thanks to Roberto Nibali who found
the problem and tested a 2.4.32-rc2 patch, which is equal to this
2.6 version. Patch for 2.4 is already sent to Marcelo.
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Roberto Nibali <ratz@drugphish.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ipvs/ip_vs_core.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/net/ipv4/ipvs/ip_vs_core.c b/net/ipv4/ipvs/ip_vs_core.c index 981cc3244ef2..1a0843cd58a9 100644 --- a/net/ipv4/ipvs/ip_vs_core.c +++ b/net/ipv4/ipvs/ip_vs_core.c @@ -1009,11 +1009,10 @@ ip_vs_in(unsigned int hooknum, struct sk_buff **pskb, if (sysctl_ip_vs_expire_nodest_conn) { /* try to expire the connection immediately */ ip_vs_conn_expire_now(cp); - } else { - /* don't restart its timer, and silently - drop the packet. */ - __ip_vs_conn_put(cp); } + /* don't restart its timer, and silently + drop the packet. */ + __ip_vs_conn_put(cp); return NF_DROP; } |