diff options
| author |   Cong Wang <cong.wang@bytedance.com> | 2021-06-14 19:13:37 -0700 |
|---|---|---|
| committer |   Daniel Borkmann <daniel@iogearbox.net> | 2021-06-21 16:48:24 +0200 |
| commit | e00a5c331bf57f41fcfdc5da4f5caeafe5e54c1d (patch) | |
| tree | 6f0ad4fe45fb3f3edf9ba7427d63d527a363722d /net | |
| parent | selftests/bpf: Retry for EAGAIN in udp_redir_to_connected() (diff) | |
| download | linux-dev-e00a5c331bf57f41fcfdc5da4f5caeafe5e54c1d.tar.xz linux-dev-e00a5c331bf57f41fcfdc5da4f5caeafe5e54c1d.zip | |
udp: Fix a memory leak in udp_read_sock()
sk_psock_verdict_recv() clones the skb and uses the clone
afterward, so udp_read_sock() should free the skb after using
it, regardless of error or not.
This fixes a real kmemleak.
Fixes: d7f571188ecf ("udp: Implement ->read_sock() for sockmap")
Signed-off-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/20210615021342.7416-4-xiyou.wangcong@gmail.com
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/udp.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 1307ad0d3b9e..8091276cb85b 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -1798,11 +1798,13 @@ int udp_read_sock(struct sock *sk, read_descriptor_t *desc, if (used <= 0) { if (!copied) copied = used; + kfree_skb(skb); break; } else if (used <= skb->len) { copied += used; } + kfree_skb(skb); if (!desc->count) break; } |