diff options
| author |   David Ahern <dsahern@kernel.org> | 2019-11-07 18:29:52 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-11-07 16:14:36 -0800 |
| commit | e0a312629fefa943534fc46f7bfbe6de3fdaf463 (patch) | |
| tree | e198faf564c9abbc25341cf972f403e325395607 /net | |
| parent | ipv6: fixes rt6_probe() and fib6_nh->last_probe init (diff) | |
| download | linux-dev-e0a312629fefa943534fc46f7bfbe6de3fdaf463.tar.xz linux-dev-e0a312629fefa943534fc46f7bfbe6de3fdaf463.zip | |
ipv4: Fix table id reference in fib_sync_down_addr
Hendrik reported routes in the main table using source address are not
removed when the address is removed. The problem is that fib_sync_down_addr
does not account for devices in the default VRF which are associated
with the main table. Fix by updating the table id reference.
Fixes: 5a56a0b3a45d ("net: Don't delete routes in different VRFs")
Reported-by: Hendrik Donner <hd@os-cillation.de>
Signed-off-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/fib_semantics.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index 0913a090b2bf..f1888c683426 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1814,8 +1814,8 @@ int fib_sync_down_addr(struct net_device *dev, __be32 local) int ret = 0; unsigned int hash = fib_laddr_hashfn(local); struct hlist_head *head = &fib_info_laddrhash[hash]; + int tb_id = l3mdev_fib_table(dev) ? : RT_TABLE_MAIN; struct net *net = dev_net(dev); - int tb_id = l3mdev_fib_table(dev); struct fib_info *fi; if (!fib_info_laddrhash || local == 0) |