diff options
| author |   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> | 2021-06-28 16:13:44 -0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-28 15:34:50 -0700 |
| commit | ef6c8d6ccf0c1dccdda092ebe8782777cd7803c9 (patch) | |
| tree | b08b00cc08cbff3c1b2e55979fc72f7e31dfa6f1 /net | |
| parent | sctp: validate chunk size in __rcv_asconf_lookup (diff) | |
| download | linux-dev-ef6c8d6ccf0c1dccdda092ebe8782777cd7803c9.tar.xz linux-dev-ef6c8d6ccf0c1dccdda092ebe8782777cd7803c9.zip | |
sctp: add param size validation for SCTP_PARAM_SET_PRIMARY
When SCTP handles an INIT chunk, it calls for example:
sctp_sf_do_5_1B_init
sctp_verify_init
sctp_verify_param
sctp_process_init
sctp_process_param
handling of SCTP_PARAM_SET_PRIMARY
sctp_verify_init() wasn't doing proper size validation and neither the
later handling, allowing it to work over the chunk itself, possibly being
uninitialized memory.
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/sm_make_chunk.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index f33a870b483d..587fb3cb88e2 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c @@ -2166,9 +2166,16 @@ static enum sctp_ierror sctp_verify_param(struct net *net, break; case SCTP_PARAM_SET_PRIMARY: - if (ep->asconf_enable) - break; - goto unhandled; + if (!ep->asconf_enable) + goto unhandled; + + if (ntohs(param.p->length) < sizeof(struct sctp_addip_param) + + sizeof(struct sctp_paramhdr)) { + sctp_process_inv_paramlength(asoc, param.p, + chunk, err_chunk); + retval = SCTP_IERROR_ABORT; + } + break; case SCTP_PARAM_HOST_NAME_ADDRESS: /* Tell the peer, we won't support this param. */ |