diff options
| author |   Bhagavathi Perumal S <bperumal@codeaurora.org> | 2019-04-16 12:54:40 +0530 |
|---|---|---|
| committer |   Johannes Berg <johannes.berg@intel.com> | 2019-04-23 13:45:30 +0200 |
| commit | f1267cf3c01b12e0f843fb6a7450a7f0b2efab8a (patch) | |
| tree | 61c56e84ac62fd4739c2e869f8713adbb30baa84 /net | |
| parent | mac80211: fix RX STBC override byte order (diff) | |
| download | linux-dev-f1267cf3c01b12e0f843fb6a7450a7f0b2efab8a.tar.xz linux-dev-f1267cf3c01b12e0f843fb6a7450a7f0b2efab8a.zip | |
mac80211: Fix kernel panic due to use of txq after free
The txq of vif is added to active_txqs list for ATF TXQ scheduling
in the function ieee80211_queue_skb(), but it was not properly removed
before freeing the txq object. It was causing use after free of the txq
objects from the active_txqs list, result was kernel panic
due to invalid memory access.
Fix kernel invalid memory access by properly removing txq object
from active_txqs list before free the object.
Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/mac80211/iface.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 4a6ff1482a9f..02d2e6f11e93 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1908,6 +1908,9 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata) list_del_rcu(&sdata->list); mutex_unlock(&sdata->local->iflist_mtx); + if (sdata->vif.txq) + ieee80211_txq_purge(sdata->local, to_txq_info(sdata->vif.txq)); + synchronize_rcu(); if (sdata->dev) { |