diff options
author | 2019-05-17 13:20:11 -0400 | |
---|---|---|
committer | 2019-05-28 13:10:49 -0400 | |
commit | ee1c71a8e1456ab53fe667281d855849edf26a4d (patch) | |
tree | 70ffac1ed3ade7cbaae59530feba0af01ffc657c /samples/v4l/v4l2-pci-skeleton.c | |
parent | media: v4l2-core: fix use-after-free error (diff) | |
download | linux-dev-ee1c71a8e1456ab53fe667281d855849edf26a4d.tar.xz linux-dev-ee1c71a8e1456ab53fe667281d855849edf26a4d.zip |
media: vimc: fix component match compare
If the system has other devices being registered in the component
framework, the compare function will be called with a device that
doesn't belong to vimc.
This device is not necessarily a platform_device, nor have a
platform_data (which causes a NULL pointer dereference error) and if it
does have a pdata, it is not necessarily type of struct vimc_platform_data.
So casting to any of these types is wrong.
Instead of expecting a given pdev with a given pdata, just expect for
the device it self. vimc-core is the one who creates them, we know in
advance exactly which object to expect in the match.
Fixes: 4a29b7090749 ("[media] vimc: Subdevices as modules")
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Tested-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'samples/v4l/v4l2-pci-skeleton.c')
0 files changed, 0 insertions, 0 deletions