diff options
| author | 2021-07-26 17:23:18 -0700 | |
|---|---|---|
| committer | 2021-07-27 17:31:33 -0700 | |
| commit | 1e98d8c52ed5dfbaf273c4423c636525c2ce59e7 (patch) | |
| tree | 0d5fc8f28363360a0b02bc59d5cd1bf65853d5c5 /scripts/basic | |
| parent | drm/i915/guc: Make hangcheck work with GuC virtual engines (diff) | |
drm/i915: Hold reference to intel_context over life of i915_request
Hold a reference to the intel_context over life of an i915_request.
Without this an i915_request can exist after the context has been
destroyed (e.g. request retired, context closed, but user space holds a
reference to the request from an out fence). In the case of GuC
submission + virtual engine, the engine that the request references is
also destroyed which can trigger bad pointer dref in fence ops (e.g.
i915_fence_get_driver_name). We could likely change
i915_fence_get_driver_name to avoid touching the engine but let's just
be safe and hold the intel_context reference.
v2:
(John Harrison)
- Update comment explaining how GuC mode and execlists mode deal with
virtual engines differently
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210727002348.97202-4-matthew.brost@intel.com
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions
