diff options
| author |   Julia Lawall <julia@diku.dk> | 2009-02-04 22:17:29 +0100 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@HansenPartnership.com> | 2009-03-12 12:58:13 -0500 |
| commit | aa6cd29b72a5d8e6e5c8f536bc48693824ebfe09 (patch) | |
| tree | 78b7a67a5f44d0cd12e993471fc0c403819b296d /scripts/basic | |
| parent | [SCSI] Make scsi.h independent of the rest of the scsi includes (diff) | |
[SCSI] libfc: Correct use of ! and &
!ep->esb_stat is either 1 or 0, and the rightmost bit of ESB_ST_COMPLETE is
always 0, making the result of !ep->esb_stat & ESB_ST_COMPLETE always 0.
Thus parentheses around the argument to ! seem needed.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@ expression E; constant C; @@
(
!E & !C
|
- !E & C
+ !(E & C)
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions