aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/checkpatch.pl
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2013-07-03 15:05:28 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2013-07-03 16:07:44 -0700
commitc4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28 (patch)
treef3d0d23c8664d6f8ebcda37f3617b8ecbe5660dc /scripts/checkpatch.pl
parentcheckpatch: reduce false positive rate of "complex macros" (diff)
downloadlinux-dev-c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28.tar.xz
linux-dev-c4a62ef9102bfa39f3bb89be2ae1ae11a23ebe28.zip
checkpatch: add a placeholder to check blank lines before declarations
Figure out first how to determine if this is in a struct declaration or in a function body before enabling this. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-xscripts/checkpatch.pl8
1 files changed, 8 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 93b8e6693cb1..4ad40523b419 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2750,6 +2750,14 @@ sub process {
"space required before the open brace '{'\n" . $herecurr);
}
+## # check for blank lines before declarations
+## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
+## $prevrawline =~ /^.\s*$/) {
+## WARN("SPACING",
+## "No blank lines before declarations\n" . $hereprev);
+## }
+##
+
# closing brace should have a space following it when it has anything
# on the line
if ($line =~ /}(?!(?:,|;|\)))\S/) {