diff options
| author | 2014-04-17 10:07:54 -0700 | |
|---|---|---|
| committer | 2014-04-22 10:21:30 -0700 | |
| commit | 9fba5ead79b996f97e80a670eabab75538a7422a (patch) | |
| tree | ace72ba941d5e598c6a6d9ad2b2b8227ab59cf60 /scripts/checkstack.pl | |
| parent | staging: comedi: amplc_dio200_common: fix the cmd->start_arg use (diff) | |
staging: comedi: amplc_pci224: fix the ao cmd->start_arg use
This driver supports two cmd->start_src values, TRIG_INT and TRIG_EXT. For
TRIG_INT sources, the cmd->start_arg is actually the valid trig_num that is
passed to the async (*inttrig) callback. This driver trivially validates the
arg for this source to be 0.
Refactor the (*inttrig) so that the cmd->start_arg is used to check the trig_num
instead of the open coded value.
For aesthetics, refactor the (*do_cmd) to use if/else instead of the switch when
handling the cmd->start_src. All code paths do the spin lock/unlock so move those
out of the if/else.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'scripts/checkstack.pl')
0 files changed, 0 insertions, 0 deletions
