diff options
| author |   Kees Cook <keescook@chromium.org> | 2021-09-29 15:02:18 -0700 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2021-10-15 11:25:13 +0200 |
| commit | cf2a85efdade117e2169d6e26641016cbbf03ef0 (patch) | |
| tree | 9cc8c9b939d1f86e0665cf809b5897dac214ead7 /scripts | |
| parent | Revert "proc/wchan: use printk format instead of lookup_symbol_name()" (diff) | |
| download | linux-dev-cf2a85efdade117e2169d6e26641016cbbf03ef0.tar.xz linux-dev-cf2a85efdade117e2169d6e26641016cbbf03ef0.zip | |
leaking_addresses: Always print a trailing newline
For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.
Unconditionally remove the newline on input, and write it back out on
output.
[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211008111626.151570317@infradead.org
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/leaking_addresses.pl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl index b2d8b8aa2d99..8f636a23bc3f 100755 --- a/scripts/leaking_addresses.pl +++ b/scripts/leaking_addresses.pl @@ -455,8 +455,9 @@ sub parse_file open my $fh, "<", $file or return; while ( <$fh> ) { + chomp; if (may_leak_address($_)) { - print $file . ': ' . $_; + printf("$file: $_\n"); } } close $fh; |