diff options
| author |   Roberto Sassu <roberto.sassu@huawei.com> | 2020-04-14 10:01:31 +0200 |
|---|---|---|
| committer |   Mimi Zohar <zohar@linux.ibm.com> | 2020-05-07 23:36:25 -0400 |
| commit | 0c4395fb2aa77341269ea619c5419ea48171883f (patch) | |
| tree | 174d1f6258d9d28eb1c380de418eb2a9a49b314f /security/integrity/evm/evm_crypto.c | |
| parent | ima: Set again build_ima_appraise variable (diff) | |
| download | linux-dev-0c4395fb2aa77341269ea619c5419ea48171883f.tar.xz linux-dev-0c4395fb2aa77341269ea619c5419ea48171883f.zip | |
evm: Fix possible memory leak in evm_calc_hmac_or_hash()
Don't immediately return if the signature is portable and security.ima is
not present. Just set error so that memory allocated is freed before
returning from evm_calc_hmac_or_hash().
Fixes: 50b977481fce9 ("EVM: Add support for portable signature format")
Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Diffstat (limited to 'security/integrity/evm/evm_crypto.c')
| -rw-r--r-- | security/integrity/evm/evm_crypto.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/integrity/evm/evm_crypto.c b/security/integrity/evm/evm_crypto.c index 35682852ddea..499ea01b2edc 100644 --- a/security/integrity/evm/evm_crypto.c +++ b/security/integrity/evm/evm_crypto.c @@ -241,7 +241,7 @@ static int evm_calc_hmac_or_hash(struct dentry *dentry, /* Portable EVM signatures must include an IMA hash */ if (type == EVM_XATTR_PORTABLE_DIGSIG && !ima_present) - return -EPERM; + error = -EPERM; out: kfree(xattr_value); kfree(desc); |