diff options
| author |   Yang Guo <guoyang2@huawei.com> | 2019-12-12 10:02:24 +0800 |
|---|---|---|
| committer |   Paul Moore <paul@paul-moore.com> | 2019-12-12 08:50:39 -0500 |
| commit | 210a292874517782bed2e2220c7beb1608d3b05d (patch) | |
| tree | ff1a822ba3402df91a1105ea77e37ac5a08dc717 /security/selinux/hooks.c | |
| parent | selinux: ensure we cleanup the internal AVC counters on error in avc_insert() (diff) | |
| download | linux-dev-210a292874517782bed2e2220c7beb1608d3b05d.tar.xz linux-dev-210a292874517782bed2e2220c7beb1608d3b05d.zip | |
selinux: remove unnecessary selinux cred request
task_security_struct was obtained at the beginning of may_create
and selinux_inode_init_security, no need to obtain again.
may_create will be called very frequently when create dir and file.
Cc: Paul Moore <paul@paul-moore.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Eric Paris <eparis@parisplace.org>
Signed-off-by: Yang Guo <guoyang2@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security/selinux/hooks.c')
| -rw-r--r-- | security/selinux/hooks.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 47626342b6e5..40ec866e48da 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -1833,8 +1833,8 @@ static int may_create(struct inode *dir, if (rc) return rc; - rc = selinux_determine_inode_label(selinux_cred(current_cred()), dir, - &dentry->d_name, tclass, &newsid); + rc = selinux_determine_inode_label(tsec, dir, &dentry->d_name, tclass, + &newsid); if (rc) return rc; @@ -2906,8 +2906,7 @@ static int selinux_inode_init_security(struct inode *inode, struct inode *dir, newsid = tsec->create_sid; - rc = selinux_determine_inode_label(selinux_cred(current_cred()), - dir, qstr, + rc = selinux_determine_inode_label(tsec, dir, qstr, inode_mode_to_security_class(inode->i_mode), &newsid); if (rc) |